Allon Mureinik has posted comments on this change.
Change subject: core: Fix dao tests not to print lookup error
......................................................................
Patch Set 1: (2 inline comments)
like the idea, have issues with the implementation - see inline.
....................................................
File
backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/BaseDAOTestCase.java
Line 54: private static IDataSet dataset;
Line 55:
Line 56: @BeforeClass
Line 57: public static void initTestCase() throws Exception {
Line 58: EjbUtils.setStrategy(new DaoTestEjbUtilsStrategy());
You should have an @AfterClass method that unsets this.
Using @MockEJBStrategeyRule could save you the trouble, IIRC
Line 59: if(dataSource == null) {
Line 60: dataSource = createDataSource();
Line 61:
Line 62: dataset = initDataSet();
Line 61:
Line 62: dataset = initDataSet();
Line 63: dbFacade = DbFacadeLocator.getDbFacade();
Line 64:
dbFacade.setDbEngineDialect(DbFacadeLocator.loadDbEngineDialect());
Line 65:
//dbFacade.setTemplate(dbFacade.getDbEngineDialect().createJdbcTemplate(dataSource));
Please remove this line instead of commenting it out.
Line 66: // load data from fixtures to DB
Line 67: DatabaseOperation.CLEAN_INSERT.execute(getConnection(),
dataset);
Line 68: }
Line 69: }
--
To view, visit http://gerrit.ovirt.org/12176
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f37acaea5c21463c4e126799524a3c41b6071a3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
