Juan Hernandez has posted comments on this change. Change subject: core, webadmin: i18n splash screen. ......................................................................
Patch Set 11: Looks good to me, but someone else must approve (1 inline comment) There some white space issues, please fix them before merging. .................................................... File backend/manager/modules/root/src/main/webapp/WEB-INF/web.xml Line 156: <error-page> Line 157: <error-code>404</error-code> Line 158: <location>/404.html</location> Line 159: </error-page> Line 160: Maybe a comment here explaining that this URL is handled by the filter? Line 161: <welcome-file-list> Line 162: <welcome-file>index</welcome-file> Line 163: </welcome-file-list> -- To view, visit http://gerrit.ovirt.org/10065 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I37156061cbdd7d2df3290c88dee933c41e0087c5 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <[email protected]> Gerrit-Reviewer: Alexander Wels <[email protected]> Gerrit-Reviewer: Einav Cohen <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Vojtech Szocs <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
