Alissa Bonas has posted comments on this change.

Change subject: core: Remove JBoss specific logging from bll
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File backend/manager/modules/bll/src/test/resources/log4j.xml
Line 229:    <!-- Clustering logging -->
Line 230:    <!-- Uncomment the following to redirect the org.jgroups and
Line 231:       org.jboss.ha categories to a cluster.log file.
Line 232: 
Line 233:    <appender name="CLUSTER" 
class="org.apache.log4j.RollingFileAppender">
Do you know if this entire commented out section relevant at all? If yes, then 
it's good to fix the package names in it, if not - maybe better to remove it 
from the file? (not necessarily in this patch, of course)
Line 234:      <errorHandler 
class="org.apache.log4j.helpers.OnlyOnceErrorHandler"/>
Line 235:      <param name="File" value="${jboss.server.log.dir}/cluster.log"/>
Line 236:      <param name="Append" value="false"/>
Line 237:      <param name="MaxFileSize" value="500KB"/>


--
To view, visit http://gerrit.ovirt.org/12168
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6988196004df741f37ce4971327c005e068cca5b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to