Sandro Bonazzola has posted comments on this change. Change subject: packaging: Fix text aligned not properly for long strings. ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) I think that using the textwrap module will be a better choice: http://docs.python.org/2/library/textwrap.html .................................................... File packaging/fedora/setup/engine-upgrade.py Line 574: logging.debug("Post script completed successfully") Line 575: Line 576: def runFunc(funcList, dispString): Line 577: sys.stdout.write("%s..." % dispString) Line 578: sys.stdout.flush() Couldn't we use textwrap? http://docs.python.org/2/library/textwrap.html Line 579: if len(dispString) > 69: Line 580: # Split by lines (\n), and work with last part (may be empty string): Line 581: dispString = dispString.split('\n')[-1] Line 582: -- To view, visit http://gerrit.ovirt.org/12194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id242e8a247ae720b3aeb37f40004241dfc3920de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
