Chris Morrissey has posted comments on this change.
Change subject: restapi: add /disks sub-collection to /storagedomain resource
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainDisksResourceTest.java
Line 28:
Line 29: public class BackendStorageDomainDisksResourceTest extends
AbstractBackendCollectionResourceTest<Disk,
org.ovirt.engine.core.common.businessentities.Disk, BackendDisksResource> {
Line 30:
Line 31: public BackendStorageDomainDisksResourceTest() {
Line 32: super(new BackendDisksResource(), SearchType.Disk, "Disks : ");
Shouldn't this be calling super with a new BackendStorageDomainDisksResource?
Line 33: }
Line 34:
Line 35: @Override
Line 36: protected List<Disk> getCollection() {
--
To view, visit http://gerrit.ovirt.org/10337
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6c18e5b28e81f13b44e9431efd623a5627379a1
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Chris Morrissey <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ori Liel <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches