Allon Mureinik has uploaded a new change for review. Change subject: build: NlsCheck - unwrap else clause ......................................................................
build: NlsCheck - unwrap else clause Unwrapped a useless else clause, since the if clause does not terminate properly (it returns from the function). Change-Id: Ie0d43d0402f948dd5f0c45279fc19a2997d7f27b Signed-off-by: Allon Mureinik <[email protected]> --- M build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/50/12250/1 diff --git a/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java b/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java index 6afc30e..c60e40d 100644 --- a/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java +++ b/build-tools-root/ovirt-checkstyle-extension/src/main/java/checks/NlsCheck.java @@ -119,9 +119,8 @@ if (isValidEnd) { return startIndex; - } else { - startIndex = lineText.indexOf(")", startIndex + 1); } + startIndex = lineText.indexOf(")", startIndex + 1); } return -1; } -- To view, visit http://gerrit.ovirt.org/12250 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ie0d43d0402f948dd5f0c45279fc19a2997d7f27b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
