Sahina Bose has posted comments on this change. Change subject: engine: Get gluster hooks query ......................................................................
Patch Set 11: (3 inline comments) .................................................... File backend/manager/dbscripts/gluster_hooks_sp.sql Line 79: WHERE cluster_id = v_cluster_id AND gluster_command = v_gluster_command AND stage = v_stage AND name = v_name; Line 80: END; $procedure$ Line 81: LANGUAGE plpgsql; Line 82: Line 83: Is there a need for this stored proc? Shouldn't this be done in DeleteGlusterHookByName as first step before deleting from gluster_hooks? Line 84: Create or replace FUNCTION DeleteGlusterServerHooksByName(v_cluster_id UUID, Line 85: v_gluster_command VARCHAR(1000), Line 86: v_stage VARCHAR(100), Line 87: v_name VARCHAR(1000)) Line 147: v_gluster_command VARCHAR(1000), Line 148: v_stage VARCHAR(100), Line 149: v_name VARCHAR(1000), Line 150: v_content_type VARCHAR(100), Line 151: v_in_sync boolean) I think cluster_id parameter is not required as Gluster hook can be uniquely identified by id Line 152: RETURNS VOID Line 153: AS $procedure$ Line 154: BEGIN Line 155: UPDATE gluster_hooks .................................................... File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterHooksDao.java Line 17: Line 18: public void save(GlusterHookEntity glusterHook); Line 19: Line 20: public GlusterHookEntity getById(Guid id); Line 21: Minor: the name of the method is inconsistent with it's parameters. Same for removeByName Line 22: public GlusterHookEntity getByName(Guid clusterId, String glusterCommand, GlusterHookStage stage, String hookName); Line 23: Line 24: public List<GlusterHookEntity> getByClusterId(Guid clusterId); Line 25: -- To view, visit http://gerrit.ovirt.org/10650 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8b2d261ead720fccea6884acbc806ec79e52b36 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Itamar Heim <[email protected]> Gerrit-Reviewer: Kanagaraj M <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Sahina Bose <[email protected]> Gerrit-Reviewer: Selvasundaram <[email protected]> Gerrit-Reviewer: Shireesh Anjal <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
