Allon Mureinik has posted comments on this change.
Change subject: core: Update StoragePoolValidator test to test GlusterFS.
......................................................................
Patch Set 12: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddEmptyStoragePoolCommand.java
Line 69:
addCanDoActionMessage(VersionSupport.getUnsupportedVersionMessage());
Line 70: result = false;
Line 71: } else if
(!validate(storagePoolValidator.isPosixDcAndMatchingCompatiblityVersion())) {
Line 72: result = false;
Line 73: } else if
(!validate(storagePoolValidator.isGlusterDcAndMatchingCompatiblityVersion())) {
I'm not sure if it should be a part of this patch or not, but all these
if-elses are becoming quite annoying.
Perhaps its time to generalize this block
Line 74: result = false;
Line 75: }
Line 76: return result;
Line 77: }
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/StoragePoolValidatorTest.java
Line 30: mockConfig(ConfigValues.PosixStorageEnabled,
"general", false),
Line 31: mockConfig(ConfigValues.GlusterFsStorageEnabled,
Version.v3_1.toString(), false),
Line 32: mockConfig(ConfigValues.GlusterFsStorageEnabled,
Version.v3_2.toString(), false),
Line 33: mockConfig(ConfigValues.GlusterFsStorageEnabled,
Version.v3_0.toString(), false),
Line 34: mockConfig(ConfigValues.GlusterFsStorageEnabled,
Version.v3_3.toString(), true));
Take a look at patch 26c357c1b99496b8f0bb005273c8ec93cd1bcd69 - you can use a
Version instance directly in MockConfigRule, no need for the toString()
Line 35:
Line 36: private StoragePoolValidator validator = null;
Line 37: private storage_pool storagePool = null;
Line 38:
--
To view, visit http://gerrit.ovirt.org/8836
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4cd98cd06716c31248d8ec4f21a3a6f79f13102
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Deepak C Shetty <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Sharad Mishra <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
