Allon Mureinik has uploaded a new change for review. Change subject: core: Remove PropertyCompat ......................................................................
core: Remove PropertyCompat PropertyCompat was an empty extension to PropertyInfo, with no additional logic of it's own, and hence pretty redundant. This patch removes it, replaces the single place it was used (TypeCompat) with PropertyInfo and renames the test accordingly. Change-Id: I21cfe23038e2647ee7ce816b532cb28f067ac826 Signed-off-by: Allon Mureinik <[email protected]> --- D backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyCompat.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java R backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java 3 files changed, 5 insertions(+), 17 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/12257/1 diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyCompat.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyCompat.java deleted file mode 100644 index 7abe2c5..0000000 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/PropertyCompat.java +++ /dev/null @@ -1,12 +0,0 @@ -package org.ovirt.engine.core.compat.backendcompat; - -import java.beans.PropertyDescriptor; - -// This will be a wrapper for import java.beans.PropertyDescriptor; -public class PropertyCompat extends PropertyInfo { - - public PropertyCompat(PropertyDescriptor pd) { - super(pd); - } - -} diff --git a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java index 63d3333..c28eb36 100644 --- a/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java +++ b/backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/backendcompat/TypeCompat.java @@ -33,12 +33,12 @@ return returnValue; } - public static PropertyCompat GetProperty(Class<?> type, String idField) { + public static PropertyInfo GetProperty(Class<?> type, String idField) { try { PropertyDescriptor[] pds = Introspector.getBeanInfo(type).getPropertyDescriptors(); for (PropertyDescriptor pd : pds) { if (pd.getName().equalsIgnoreCase(idField)) { - return new PropertyCompat(pd); + return new PropertyInfo(pd); } } } catch (Exception e) { diff --git a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyCompatTest.java b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java similarity index 86% rename from backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyCompatTest.java rename to backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java index eee14ee..b8cdd59 100644 --- a/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyCompatTest.java +++ b/backend/manager/modules/compat/src/test/java/org/ovirt/engine/core/compat/PropertyInfoTest.java @@ -10,15 +10,15 @@ import java.util.Set; import org.junit.Test; -import org.ovirt.engine.core.compat.backendcompat.PropertyCompat; +import org.ovirt.engine.core.compat.backendcompat.PropertyInfo; import org.ovirt.engine.core.compat.backendcompat.TypeCompat; -public class PropertyCompatTest { +public class PropertyInfoTest { private String someValue = "Anakin"; @Test public void testIt() { - PropertyCompat pc = TypeCompat.GetProperty(this.getClass(), "someValue"); + PropertyInfo pc = TypeCompat.GetProperty(this.getClass(), "someValue"); String result = (String) pc.GetValue(this, "JarJar"); assertEquals("Standard", "Anakin", result); this.someValue = null; -- To view, visit http://gerrit.ovirt.org/12257 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I21cfe23038e2647ee7ce816b532cb28f067ac826 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
