Allon Mureinik has posted comments on this change.
Change subject: core: VmRunHandler: snapshot check on diskless VMs
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmRunHandler.java
Line 103:
message.add(VdcBllMessages.VM_CANNOT_RUN_FROM_NETWORK_WITHOUT_NETWORK.toString());
Line 104: retValue = false;
Line 105: }
Line 106:
Line 107: if (retValue) {
This check was done after the images checks (see to the right).
Don't want to muck around with the flow too much if I don't absolutely have to,
but not doing it on a diskelss VM is clearly a bug.
Line 108: ValidationResult vmNotLockedResult = new
VmValidator(vm).vmNotLocked();
Line 109: if (!vmNotLockedResult.isValid()) {
Line 110:
message.add(vmNotLockedResult.getMessage().name());
Line 111: retValue = false;
Line 122
Line 123
Line 124
Line 125
Line 126
The original place of the check
Line 129: retValue = false;
Line 130: }
Line 131:
Line 132: if (retValue &&
!performImageChecksForRunningVm(vm, message, runParams, vmDisks)) {
Line 133: retValue = false;
agreed, will fix.
Line 134: }
Line 135:
Line 136: // Check if iso and floppy path exists
Line 137: if (retValue && !vm.isAutoStartup()
--
To view, visit http://gerrit.ovirt.org/12246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I232971b0d92aed1266d51ef89b2ae8175f08fbb2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
