Allon Mureinik has posted comments on this change.
Change subject: Add detailed note to user when password validation fails by
using engine-config
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java
Line 139: this.parser = parser;
Line 140: }
Line 141:
Line 142: public String getHelpNote() {
Line 143: String s = "\n\n\n" +
please use StringFormat and %n instead of \n, so we're less platform dependent.
Line 144: "### Notes:\n" +
Line 145: "## 1. Passwords: password can be set in
interactive mode ie:\n" +
Line 146: "### engine-config -s
PasswordEntry=interactive\n" +
Line 147: "### or via file with one of the following
options:\n" +
--
To view, visit http://gerrit.ovirt.org/12153
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ae53d9b19f1b09990cf540d56e648698a00233d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Stephen Gordon <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
