Michael Kublin has posted comments on this change.
Change subject: core: Clean "only in db" async tasks
......................................................................
Patch Set 7: Looks good to me, approved
(1 inline comment)
can be merged, but please fix before small comment inside
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java
Line 185:
Line 186: if
(task.getParameters().getDbAsyncTask().getStartTime().getTime() < maxTime) {
Line 187: AuditLogableBase logable = new AuditLogableBase();
Line 188: logable.addCustomValue("CommandName",
task.getParameters().getDbAsyncTask().getaction_type().toString());
Line 189: logable.addCustomValue("Dat)e",
task.getParameters().getDbAsyncTask().getStartTime().toString());
please remove ): Da)te = Date
Line 190:
Line 191: // if task is not finish and not unknown then it's in
running
Line 192: // status
Line 193: if (task.getLastTaskStatus().getStatus() !=
AsyncTaskStatusEnum.finished
--
To view, visit http://gerrit.ovirt.org/12055
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie13ae21eaadb1bb621a7fc8ad471e60387a3699b
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
