Alex Lourie has uploaded a new change for review. Change subject: packaging: updated executing backupDB function ......................................................................
packaging: updated executing backupDB function Calling backupDB function from the setup flow was incorrect. This patch fixes that behavior by supplying named parameters to the function and making sure that all the parameters are correct. Change-Id: Icef79b53992210c547af13deffd57039fa43e9b0 Bug-Url: https://bugzilla.redhat.com/913176 Signed-off-by: Alex Lourie <[email protected]> (cherry picked from commit b8928be5aac72a7267023a66e19e9972341bf2e8) --- M packaging/fedora/setup/engine-setup.py 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/12274/1 diff --git a/packaging/fedora/setup/engine-setup.py b/packaging/fedora/setup/engine-setup.py index 29af270..0c745d4 100755 --- a/packaging/fedora/setup/engine-setup.py +++ b/packaging/fedora/setup/engine-setup.py @@ -1140,7 +1140,14 @@ logging.debug("backing up %s db to file %s"%(basedefs.DB_NAME, dbBackupFile)) # Run db backup - utils.backupDB(basedefs.DB_NAME, getDbUser(), dbBackupFile, getDbHostName(), getDbPort()) + utils.backupDB( + db=basedefs.DB_NAME, + backup_file=dbBackupFile, + env=utils.getPgPassEnv(), + user=getDbUser(), + host=getDbHostName(), + port=getDbPort(), + ) # Rename DB first. If it fails - stop with "active connections" error. # if upgrade passes fine, rename the DB back. -- To view, visit http://gerrit.ovirt.org/12274 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icef79b53992210c547af13deffd57039fa43e9b0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.2 Gerrit-Owner: Alex Lourie <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
