Alissa Bonas has posted comments on this change. Change subject: core: VmRunHandler: simplify isInternal evaluation ......................................................................
Patch Set 2: (1 inline comment) .................................................... Commit Message Line 12: Line 13: Since java evaluated boolean conditions with short circuit logic, this Line 14: can be simplified. Line 15: The right hand of the || condition is only tested if Line 16: !vm.isAutoStartup() evaluates to fale, which means vm.isAutoStartup if you touch the patch again, please fix fale to false. but don't waste time on that on purpose. Line 17: evaluated to true - so there is no reason to test it again. Line 18: Line 19: The added readability is a bonus. Line 20: -- To view, visit http://gerrit.ovirt.org/12248 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0aa0ce3b0ef22739014f31f4019a35b8d230aaee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
