Juan Hernandez has posted comments on this change.
Change subject: packaging: changed psql execution environment
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
Only a very minor comment inside.
....................................................
File packaging/fedora/setup/common_utils.py
Line 426: answer = True
Line 427: logging.debug("TCP port %s is open by process %s, PID %s"
% (port, process, pid))
Line 428: return (answer, process, pid)
Line 429:
Line 430: def getPgPassEnv():
Looks like this is now more "getPgEnv" than "getPgPassEnv". Maybe a
documentation comment explaining that this builds the environment used to run
the postgresql commands.
Line 431: # .pgpass definition
Line 432: if os.path.exists(basedefs.DB_PASS_FILE):
Line 433: return {
Line 434: "PGPASSFILE" : basedefs.DB_PASS_FILE,
--
To view, visit http://gerrit.ovirt.org/12227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I24869748184d9397192461fa01da632a558208f7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
