Allon Mureinik has uploaded a new change for review. Change subject: core: Remove vdsGroups member from storage_pool ......................................................................
core: Remove vdsGroups member from storage_pool Removed the private member "vdsGroups" from the storage_pool class. This member was never updated (in fact, there are no methods to modify it!), and never queried (no such methods exists either), and was only used in the equals(Object) and hashCode() methods. Since its value is always null, it's useless to continue holding it. Change-Id: I5ffad5811b390fd25562e677c7d852fb24ac4284 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java 1 file changed, 0 insertions(+), 12 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/27/12327/1 diff --git a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java index 899ae23..822bddb 100644 --- a/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java +++ b/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/storage_pool.java @@ -1,7 +1,5 @@ package org.ovirt.engine.core.common.businessentities; -import java.util.Set; - import javax.validation.constraints.Pattern; import javax.validation.constraints.Size; @@ -44,10 +42,6 @@ private String LVER; private RecoveryMode recovery_mode = RecoveryMode.forValue(0); - - // TODO this is a hack to get around how the old mappings were done - // This will be redone in version 3.0 with proper relationship mapping - private Set<VDSGroup> vdsGroups; private Version version; @@ -184,7 +178,6 @@ result = prime * result + ((spmVdsId == null) ? 0 : spmVdsId.hashCode()); result = prime * result + ((status == null) ? 0 : status.hashCode()); result = prime * result + storagePoolType; - result = prime * result + ((vdsGroups == null) ? 0 : vdsGroups.hashCode()); result = prime * result + ((storagePoolFormatType == null) ? 0 : storagePoolFormatType.hashCode()); result = prime * result + ((quotaEnforcementType == null) ? 0 : quotaEnforcementType.hashCode()); return result; @@ -236,11 +229,6 @@ if (status != other.status) return false; if (storagePoolType != other.storagePoolType) - return false; - if (vdsGroups == null) { - if (other.vdsGroups != null) - return false; - } else if (!vdsGroups.equals(other.vdsGroups)) return false; if (storagePoolFormatType == null) { if (other.storagePoolFormatType != null) -- To view, visit http://gerrit.ovirt.org/12327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5ffad5811b390fd25562e677c7d852fb24ac4284 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
