Gilad Chaplik has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 1] ......................................................................
Patch Set 1: (1 inline comment) I can answer that :-) Laszlo, the class located in common and it's a simple null before equals check. comment inline. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AsyncTasks.java Line 178: return (ObjectUtils.objectsEqual(taskId, other.taskId) Line 179: && ObjectUtils.objectsEqual(stepId, other.stepId) Line 180: && ObjectUtils.objectsEqual(commandId, other.commandId) Line 181: && ObjectUtils.objectsEqual(actionParameters, other.actionParameters) Line 182: && actionType == other.actionType why we don't need to check nullity for enum classes? can't we use ObjectUtils for all the comparing (inc. primitives)? Line 183: && result == other.result Line 184: && status == other.status Line 185: && ObjectUtils.objectsEqual(startTime, other.startTime) Line 186: && ObjectUtils.objectsEqual(storagePoolId, other.storagePoolId) -- To view, visit http://gerrit.ovirt.org/12342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie9531a453a352619e8a6243ea1a5e4d0de4d1a45 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
