Yair Zaslavsky has posted comments on this change.
Change subject: engine: Propagate error message when quering for LDAP
users/groups
......................................................................
Patch Set 1: (1 inline comment)
The solution from engine core perspective looks fine , except for a minor
comment.
However, I would like to understand what is the approach to that on frontend.
Gilad, Derez , Alona - please comment.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerCommandBase.java
Line 70: } catch (RuntimeException e) {
Line 71: String msg = String.format("Failed to run command %s.
Domain is %s. User is %s.",
Line 72: getClass().getSimpleName(), getDomain(),
getLoginName());
Line 73: log.errorFormat(msg);
Line 74: setSucceeded(false);
Hmm, not sure setSucceeded to false is necessary, as by default this is set to
false (see implementation of setSucceeded, i also checked where we set it to
true).
Correct me if I'm wrong here, or if you prefer to this to "emphasize the
failure".
Line 75: _ldapReturnValue.setExceptionString(msg);
Line 76: }
Line 77: return _ldapReturnValue;
Line 78: }
--
To view, visit http://gerrit.ovirt.org/11893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I50da72d12c6d60642ad5e65b9376efc49e4ef699
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
