Doron Fediuck has posted comments on this change. Change subject: core: simplify businessentity equals() methods [part 3] ......................................................................
Patch Set 1: I would prefer that you didn't submit this (1 inline comment) Greg, please see Gilad's catch inline. Once foxed you'll have an ack. .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java Line 87: } Line 88: VmPool other = (VmPool) obj; Line 89: return (ObjectUtils.objectsEqual(id, other.id) Line 90: && ObjectUtils.objectsEqual(defaultEndTime, other.defaultEndTime) Line 91: && ObjectUtils.objectsEqual(defaultStartTime, other.defaultStartTime) Gilad, good catch. This is valid enough to get a score of '-1' for this patch if you wish to prevent a bug. Line 92: && defaultTimeInDays == other.defaultTimeInDays Line 93: && ObjectUtils.objectsEqual(parameters, other.parameters) Line 94: && ObjectUtils.objectsEqual(vdsGroupId, other.vdsGroupId) Line 95: && ObjectUtils.objectsEqual(description, other.description) -- To view, visit http://gerrit.ovirt.org/12344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I47aa91a092e4b67080cc5074c7dc61802b9d0a02 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: ofri masad <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
