Alissa Bonas has posted comments on this change.
Change subject: core: ImageHandlerTest - add missing annotation
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java
Line 50: disk1.getDiskAlias(),
Line 51: ImagesHandler.getSuggestedDiskAlias(disk1, prefix, 1));
Line 52: }
Line 53:
Line 54: @Test
how much did you raise now tests coverage :) ?
Line 55: public void testGetAllStorageIdsForImageIds() {
Line 56: Guid sdIdShared = Guid.NewGuid();
Line 57: Guid sdId1 = Guid.NewGuid();
Line 58: Guid sdId2 = Guid.NewGuid();
--
To view, visit http://gerrit.ovirt.org/12319
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I695456e660b7c4debfb3bc1de03b22420d976a8e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
