Alissa Bonas has posted comments on this change.
Change subject: core: ImagesHandler: filterImageDisks readability
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 601: * @return - List filtered of disk images.
Line 602: */
Line 603: public static List<DiskImage> filterImageDisks(Collection<?
extends Disk> listOfDisks,
Line 604: boolean allowOnlyNotShareableDisks,
Line 605: boolean allowOnlyAllowSnapshotDisks) {
I'm ok with any of the names as long as it doesn't have the word "only" twice
in it like in original patch.
Line 606: List<DiskImage> diskImages = new ArrayList<DiskImage>();
Line 607: for (Disk disk : listOfDisks) {
Line 608: if (disk.getDiskStorageType() == DiskStorageType.IMAGE &&
Line 609: (!allowOnlyNotShareableDisks ||
!disk.isShareable()) &&
--
To view, visit http://gerrit.ovirt.org/12318
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7cc2fc314e05fda6b1c6cdf39365b64fa0cfe345
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
