Alona Kaplan has posted comments on this change.
Change subject: webadmin: Fixed network sorting in VM networks popup
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
Line 454: if (hotUpdateSupported) {
Line 455: networks.add(null);
Line 456: }
Line 457:
Line 458: Collections.sort(networks, new Comparator<Network>() {
Consider creating SortableListModel with items of type SortedSet and a
Comparator.
It will make sure the items are always sorted. No matter if you setItems again
or adding items manually (getItems.add(...)).
Line 459:
Line 460: private LexoNumericComparator lexoNumeric = new
LexoNumericComparator();
Line 461:
Line 462: @Override
--
To view, visit http://gerrit.ovirt.org/12158
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5bf460633674135ba93babb6b0ffa851ca79d4d6
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
