Greg Padgett has posted comments on this change. Change subject: engine: watchdog support [wip] ......................................................................
Patch Set 1: Looks pretty good so far. (I'm amazed at the number of places that VM parameters have to be propagated.) One question: is there a reason we need the watchdog model/action in vm_static as well as vm_devices.spec_params? Using only the spec_params seems cleaner to me. -- To view, visit http://gerrit.ovirt.org/12419 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe5c36995dafcef6b3ad45a9e0ca8b0471324b70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Greg Padgett <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
