Daniel Erez has posted comments on this change.
Change subject: userportal: Optimization fixes
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/IUserPortalListModel.java
Line 308:
Line 309: return null;
Line 310: }
Line 311:
Line 312: protected void clearItemReferences() {
The method is being removed in the next patch
(http://gerrit.ovirt.org/#/c/12245/5).
Would be clearer if you squash both of these patches.
Line 313: if (items != null) {
Line 314: // Clear circular references inside the model
Line 315: for (UserPortalItemModel itemModel :
(Iterable<UserPortalItemModel>) items) {
Line 316: itemModel.clearReferences();
--
To view, visit http://gerrit.ovirt.org/12213
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I81b30a5e03d35862d92e6630aac71c70f7cd75de
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
