Allon Mureinik has posted comments on this change.
Change subject: core: simplify businessentity equals() methods [part 2]
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmPool.java
Line 85: if (getClass() != obj.getClass()) {
Line 86: return false;
Line 87: }
Line 88: VmPool other = (VmPool) obj;
Line 89: // Don't use defaultStartTime and defaultEndTime in equals
method
This is a logic change - it may be true, but I'd do it in another patch
Line 90: // as they will never match because of how they are
initialized.
Line 91: return (ObjectUtils.objectsEqual(id, other.id)
Line 92: && defaultTimeInDays == other.defaultTimeInDays
Line 93: && ObjectUtils.objectsEqual(parameters,
other.parameters)
--
To view, visit http://gerrit.ovirt.org/12416
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8e77ebc95015105b54fbb09472e38a2d36492278
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Greg Padgett <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
