Allon Mureinik has posted comments on this change. Change subject: core: Remove Path class from Compat module ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) 1. Changes in NGuid seem unrelated - please check 2. If you're going to add commons-io like we discussed, this can be done more elegantly. .................................................... File backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java Line 148: strGUID.append(AddLeadingZero(inguid[byteOrderIndices[11 % length]] & 0xFF)); Line 149: strGUID.append(AddLeadingZero(inguid[byteOrderIndices[12 % length]] & 0xFF)); Line 150: strGUID.append(AddLeadingZero(inguid[byteOrderIndices[13 % length]] & 0xFF)); Line 151: strGUID.append(AddLeadingZero(inguid[byteOrderIndices[14 % length]] & 0xFF)); Line 152: strGUID.append(AddLeadingZero(inguid[byteOrderIndices[15 % length]] & 0xFF)); How is this relevant to the patch? Line 153: Line 154: return strGUID.toString(); Line 155: Line 156: } -- To view, visit http://gerrit.ovirt.org/12429 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a4a1e051050196de692ca76e1d1cd8e51b0c86d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
