Allon Mureinik has posted comments on this change.
Change subject: core: Remove FileUtil unneeded methods
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Minor inline comment
Also, consider introducing commons-io like we discussed, but make life a whole
lot simpler
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeLocator.java
Line 78: try {
Line 79: String onStartConnectionTimeout = null;
Line 80: String connectionCheckInterval = null;
Line 81: Properties props = new Properties();
Line 82: if (new File(ENGINE_CONF_FILE).exists()) {
create the file object outside the if, so...
Line 83: // File exists, load /etc/ovirt-engine/engine.conf and
set values in DbFacade
Line 84: inputStream = new FileInputStream(ENGINE_CONF_FILE);
Line 85: props.load(inputStream);
Line 86: onStartConnectionTimeout =
props.getProperty(ON_START_CONNECTION_TIMEOUT);
Line 80: String connectionCheckInterval = null;
Line 81: Properties props = new Properties();
Line 82: if (new File(ENGINE_CONF_FILE).exists()) {
Line 83: // File exists, load /etc/ovirt-engine/engine.conf and
set values in DbFacade
Line 84: inputStream = new FileInputStream(ENGINE_CONF_FILE);
... You can here use it in the constructor
Line 85: props.load(inputStream);
Line 86: onStartConnectionTimeout =
props.getProperty(ON_START_CONNECTION_TIMEOUT);
Line 87: connectionCheckInterval =
props.getProperty(CONNECTION_CHECK_INTERVAL);
Line 88: if (!validNumber(onStartConnectionTimeout)) {
--
To view, visit http://gerrit.ovirt.org/12425
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia9aac66024e244bdbff52c3b7b86948a236ad0af
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
