Liron Aravot has posted comments on this change.
Change subject: core: Singleton row mapper for VdsStatic
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java
Line 118: public List<VdsStatic> getAll() {
Line 119: throw new NotImplementedException();
Line 120: }
Line 121:
Line 122: private final static class VdsStaticRowMapper implements
ParameterizedRowMapper<VdsStatic> {
perhaps we could just eliminate this class, but thats your choice.
Line 123: public static final VdsStaticRowMapper instance = new
VdsStaticRowMapper();
Line 124:
Line 125: @Override
Line 126: public VdsStatic mapRow(ResultSet rs, int rowNum)
--
To view, visit http://gerrit.ovirt.org/12471
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43133a64e7c7b62277464326606b376fd4306fbe
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
