Tomas Jelinek has posted comments on this change.
Change subject: ui: use real OS names
......................................................................
Patch Set 3: Looks good to me, approved
(1 inline comment)
looks ok, just one tiny comment
....................................................
File
frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/OSNamesTranslator.java
Line 11: private static final OSNamesConstants osNamesConstants =
GWT.create(OSNamesConstants.class);
Line 12:
Line 13: public String translate(VmOsType os) {
Line 14: try {
Line 15: return osNamesConstants.getString(os.name()); //$NON-NLS-1$
no need for the //$NON-NLS-1$
Line 16: } catch (MissingResourceException e) {
Line 17: return os.name();
Line 18: }
Line 19: }
--
To view, visit http://gerrit.ovirt.org/12475
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8fa85225c09fd6c00783507a8df4e96e66e87180
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
