Alon Bar-Lev has posted comments on this change.
Change subject: cli: add flag --dont-validate-cert-chain #915231
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File src/ovirtcli/options.py
Line 41: self.add_option('-C', '--cert-file', help='specify client PEM
cert-file')
Line 42: self.add_option('-A', '--ca-file', help='specify server CA
cert-file')
Line 43: self.add_option('-I', '--insecure', help='allow connecting to
SSL sites without CA certificate',
Line 44: action='store_true')
Line 45: self.add_option('-D', '--dont-validate-cert-chain', help='do
not validate server CA certificate',
Please consider using the positive term --validate-cert-chain=false /
--validate-cert-chain=no
Line 46: action='store_true')
Line 47: self.add_option('-F', '--filter', help='enables user
permission based filtering',
Line 48: action='store_true')
Line 49: self.add_option('-P', '--port', help='specify port')
....................................................
File src/ovirtcli/settings.py
Line 53: ('ovirt-shell:key_file', str, None),
Line 54: ('ovirt-shell:cert_file', str, None),
Line 55: ('ovirt-shell:ca_file', str, None),
Line 56: ('ovirt-shell:insecure', boolean, False),
Line 57: ('ovirt-shell:dont_validate_cert_chain', boolean, False),
Same... please consider using the positive term
('ovirt-shell:validate_cert_chain', boolean, True),
Line 58: ('ovirt-shell:filter', boolean, False),
Line 59: ('ovirt-shell:port', int, -1),
Line 60: ('ovirt-shell:timeout', int, -1),
Line 61: ('ovirt-shell:input_format', enum('xml'), 'xml'),
--
To view, visit http://gerrit.ovirt.org/12495
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4819ca2de9aa47c48031eb3d09016961f8880c3
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
