Gilad Chaplik has posted comments on this change.

Change subject: webadmin: check UP server before adding bricks
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickListModel.java
Line 193:                     model.getCommands().add(command);
Line 194:                     return;
Line 195:                 }
Line 196:             }
Line 197:         }), volumeEntity.getClusterName());
I'm failing on that (missing cluster name, id is there), should this patch 
depend on sth else?
Line 198:     }
Line 199: 
Line 200:     private void addBricks(GlusterVolumeEntity volumeEntity) {
Line 201: 


--
To view, visit http://gerrit.ovirt.org/11927
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I54b3c0eacbe4c94929d20738196324569ed8f3b6
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to