Muli Salem has posted comments on this change.
Change subject: webadmin: Make pinned to host error clearer.
......................................................................
Patch Set 1: (3 inline comments)
The code looks fine, a few minor issues in the commit message.
....................................................
Commit Message
Line 6:
Line 7: webadmin: Make pinned to host error clearer.
Line 8:
Line 9: If there is an error when trying to run a vm that is pinned to a host,
Line 10: the disaplyed error message should be-
typo:
disaplyed --> displayed
Line 11: - The specific error why the vm cannot run.
Line 12: - Note: The VM is pinned to Host '${VdsName}' but cannot r un on it.
Line 13:
Line 14: Change-Id: I1645a1dbe402c73c9e44545819368b01f00e3990
Line 7: webadmin: Make pinned to host error clearer.
Line 8:
Line 9: If there is an error when trying to run a vm that is pinned to a host,
Line 10: the disaplyed error message should be-
Line 11: - The specific error why the vm cannot run.
maybe:
The specific reason the vm cannot run. ?
or:
The specific error that is preventing the vm from running. ?
Line 12: - Note: The VM is pinned to Host '${VdsName}' but cannot r un on it.
Line 13:
Line 14: Change-Id: I1645a1dbe402c73c9e44545819368b01f00e3990
Line 15: Bug-Url: https://bugzilla.redhat.com/878451
Line 8:
Line 9: If there is an error when trying to run a vm that is pinned to a host,
Line 10: the disaplyed error message should be-
Line 11: - The specific error why the vm cannot run.
Line 12: - Note: The VM is pinned to Host '${VdsName}' but cannot r un on it.
r un --> run
Line 13:
Line 14: Change-Id: I1645a1dbe402c73c9e44545819368b01f00e3990
Line 15: Bug-Url: https://bugzilla.redhat.com/878451
--
To view, visit http://gerrit.ovirt.org/12460
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1645a1dbe402c73c9e44545819368b01f00e3990
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Muli Salem <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
