Doron Fediuck has posted comments on this change.

Change subject: userportal: quota used by graph doesn't get cleared
......................................................................


Patch Set 3: (1 inline comment)

....................................................
File 
frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/DoublePercentageProgressBar.java
Line 65:         this.valueB = value;
Line 66:     }
Line 67: 
Line 68:     public void setZeroValue() {
Line 69:         percentageBarB.setVisible(false);
It would be nicer to set the width to 0, as the method suggests.
Line 70:         percentageBarA.setVisible(true);
Line 71:         percentageBarA.setTitle(title);
Line 72:         percentageBarA.setStyleName(style.empty());
Line 73:         percentageBarA.setWidth(FULL_WIDTH + "%"); //$NON-NLS-1$


--
To view, visit http://gerrit.ovirt.org/12497
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic15b1ff6d0685b8c3752aa86429ab5802595f953
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to