Oved Ourfali has posted comments on this change.
Change subject: [WIP] tools: Improve engine-config help
......................................................................
Patch Set 3: (3 inline comments)
overall it looks good. As you probably know, you still need to set some helpers
there.
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/IntegerValueHelper.java
Line 60:
Line 61: @Override
Line 62: public String getHelpNote(ConfigKey key) {
Line 63: // TODO Auto-generated method stub
Line 64: return null;
?
Line 65: }
Line 66:
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java
Line 45:
Line 46: @Override
Line 47: public String getHelpNote(ConfigKey key) {
Line 48: // TODO Auto-generated method stub
Line 49: return null;
?
Line 50: }
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java
Line 37:
Line 38: @Override
Line 39: public String getHelpNote(ConfigKey key) {
Line 40: // TODO Auto-generated method stub
Line 41: return null;
?
Line 42: }
--
To view, visit http://gerrit.ovirt.org/12508
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I090d52cbc246eb9ffdd985ca6b5aeab6582c8653
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
