Allon Mureinik has uploaded a new change for review. Change subject: core: StorageDoaminSynamic Singleton row mapper ......................................................................
core: StorageDoaminSynamic Singleton row mapper Added a singleton row mapper in StorageDomainDynamicDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: Ia7a1b6e40235a37632d9f5f0ca8a5c3cd04ea4fc Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAODbFacadeImpl.java 1 file changed, 22 insertions(+), 32 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/68/12568/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAODbFacadeImpl.java index 27e9494..f949b5f 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainDynamicDAODbFacadeImpl.java @@ -11,26 +11,30 @@ public class StorageDomainDynamicDAODbFacadeImpl extends BaseDAODbFacade implements StorageDomainDynamicDAO{ + private static final class StorageDomainDynamicRowMapper implements ParameterizedRowMapper<StorageDomainDynamic> { + public static final StorageDomainDynamicRowMapper instance = new StorageDomainDynamicRowMapper(); + + @Override + public StorageDomainDynamic mapRow(ResultSet rs, int rowNum) + throws SQLException { + StorageDomainDynamic entity = new StorageDomainDynamic(); + entity.setAvailableDiskSize((Integer) rs + .getObject("available_disk_size")); + entity.setId(Guid.createGuidFromString(rs.getString("id"))); + entity.setUsedDiskSize((Integer) rs + .getObject("used_disk_size")); + return entity; + } + } + + @Override public StorageDomainDynamic get(Guid id) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("id", id); - - ParameterizedRowMapper<StorageDomainDynamic> mapper = new ParameterizedRowMapper<StorageDomainDynamic>() { - @Override - public StorageDomainDynamic mapRow(ResultSet rs, int rowNum) - throws SQLException { - StorageDomainDynamic entity = new StorageDomainDynamic(); - entity.setAvailableDiskSize((Integer) rs - .getObject("available_disk_size")); - entity.setId(Guid.createGuidFromString(rs.getString("id"))); - entity.setUsedDiskSize((Integer) rs - .getObject("used_disk_size")); - return entity; - } - }; - - return getCallsHandler().executeRead("Getstorage_domain_dynamicByid", mapper, parameterSource); + return getCallsHandler().executeRead("Getstorage_domain_dynamicByid", + StorageDomainDynamicRowMapper.instance, + parameterSource); } @@ -68,22 +72,8 @@ @Override public List<StorageDomainDynamic> getAll() { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource(); - - ParameterizedRowMapper<StorageDomainDynamic> mapper = new ParameterizedRowMapper<StorageDomainDynamic>() { - @Override - public StorageDomainDynamic mapRow(ResultSet rs, int rowNum) - throws SQLException { - StorageDomainDynamic entity = new StorageDomainDynamic(); - entity.setAvailableDiskSize((Integer) rs - .getObject("available_disk_size")); - entity.setId(Guid.createGuidFromString(rs.getString("id"))); - entity.setUsedDiskSize((Integer) rs - .getObject("used_disk_size")); - return entity; - } - }; - - return getCallsHandler().executeReadList("GetAllFromstorage_domain_dynamic", mapper, + return getCallsHandler().executeReadList("GetAllFromstorage_domain_dynamic", + StorageDomainDynamicRowMapper.instance, parameterSource); } -- To view, visit http://gerrit.ovirt.org/12568 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia7a1b6e40235a37632d9f5f0ca8a5c3cd04ea4fc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
