Allon Mureinik has uploaded a new change for review. Change subject: core: Singleton row mapper for DiskImageDynamic ......................................................................
core: Singleton row mapper for DiskImageDynamic Added a singleton row mapper for DiskImageDynamicDAO, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: Icad2f8fb8199d3b3c873cf01db999a873b13cde6 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java 1 file changed, 23 insertions(+), 19 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/71/12571/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java index be70408..d4db656 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDynamicDAODbFacadeImpl.java @@ -15,6 +15,28 @@ public class DiskImageDynamicDAODbFacadeImpl extends MassOperationsGenericDaoDbFacade<DiskImageDynamic, Guid> implements DiskImageDynamicDAO { + private static final class DiskImageDynamicRowMapper implements ParameterizedRowMapper<DiskImageDynamic> { + public static final DiskImageDynamicRowMapper instance = new DiskImageDynamicRowMapper(); + + @Override + public DiskImageDynamic mapRow(ResultSet rs, int rowNum) + throws SQLException { + DiskImageDynamic entity = new DiskImageDynamic(); + entity.setId(Guid.createGuidFromString(rs + .getString("image_id"))); + entity.setread_rate((Integer) rs.getObject("read_rate")); + entity.setwrite_rate((Integer) rs.getObject("write_rate")); + entity.setactual_size(rs.getLong("actual_size")); + entity.setReadLatency(rs.getObject("read_latency_seconds") != null ? rs.getDouble("read_latency_seconds") + : null); + entity.setWriteLatency(rs.getObject("write_latency_seconds") != null ? rs.getDouble("write_latency_seconds") + : null); + entity.setFlushLatency(rs.getObject("flush_latency_seconds") != null ? rs.getDouble("flush_latency_seconds") + : null); + return entity; + } + } + public DiskImageDynamicDAODbFacadeImpl() { super("disk_image_dynamic"); setProcedureNameForGet("Getdisk_image_dynamicByimage_id"); @@ -40,24 +62,6 @@ @Override protected ParameterizedRowMapper<DiskImageDynamic> createEntityRowMapper() { - return new ParameterizedRowMapper<DiskImageDynamic>() { - @Override - public DiskImageDynamic mapRow(ResultSet rs, int rowNum) - throws SQLException { - DiskImageDynamic entity = new DiskImageDynamic(); - entity.setId(Guid.createGuidFromString(rs - .getString("image_id"))); - entity.setread_rate((Integer) rs.getObject("read_rate")); - entity.setwrite_rate((Integer) rs.getObject("write_rate")); - entity.setactual_size(rs.getLong("actual_size")); - entity.setReadLatency(rs.getObject("read_latency_seconds") != null ? rs.getDouble("read_latency_seconds") - : null); - entity.setWriteLatency(rs.getObject("write_latency_seconds") != null ? rs.getDouble("write_latency_seconds") - : null); - entity.setFlushLatency(rs.getObject("flush_latency_seconds") != null ? rs.getDouble("flush_latency_seconds") - : null); - return entity; - } - }; + return DiskImageDynamicRowMapper.instance; } } -- To view, visit http://gerrit.ovirt.org/12571 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icad2f8fb8199d3b3c873cf01db999a873b13cde6 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
