Allon Mureinik has uploaded a new change for review. Change subject: core: Singleton row mapper for VdsStatistics ......................................................................
core: Singleton row mapper for VdsStatistics Added a singleton row mapper for VdsStatistics, as specified by http://www.ovirt.org/Backend_Coding_Standards . Change-Id: I138a81d75fd2965eb15979aa925687f64bb19fbc Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java 1 file changed, 33 insertions(+), 30 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/77/12577/1 diff --git a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java index 810767e..32b93d6 100644 --- a/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java +++ b/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStatisticsDAODbFacadeImpl.java @@ -19,41 +19,44 @@ */ public class VdsStatisticsDAODbFacadeImpl extends BaseDAODbFacade implements VdsStatisticsDAO { + private static final class VdsStatisticsRowMapper implements ParameterizedRowMapper<VdsStatistics> { + public static final VdsStatisticsRowMapper instance = new VdsStatisticsRowMapper(); + + @Override + public VdsStatistics mapRow(ResultSet rs, int rowNum) throws SQLException { + VdsStatistics entity = new VdsStatistics(); + entity.setcpu_idle(rs.getDouble("cpu_idle")); + entity.setcpu_load(rs.getDouble("cpu_load")); + entity.setcpu_sys(rs.getDouble("cpu_sys")); + entity.setcpu_user(rs.getDouble("cpu_user")); + entity.setusage_cpu_percent((Integer) rs + .getObject("usage_cpu_percent")); + entity.setusage_mem_percent((Integer) rs + .getObject("usage_mem_percent")); + entity.setusage_network_percent((Integer) rs + .getObject("usage_network_percent")); + entity.setId(Guid.createGuidFromString(rs + .getString("vds_id"))); + entity.setmem_available(rs.getLong("mem_available")); + entity.setmem_shared(rs.getLong("mem_shared")); + entity.setswap_free(rs.getLong("swap_free")); + entity.setswap_total(rs.getLong("swap_total")); + entity.setksm_cpu_percent((Integer) rs + .getObject("ksm_cpu_percent")); + entity.setksm_pages(rs.getLong("ksm_pages")); + entity.setksm_state((Boolean) rs.getObject("ksm_state")); + return entity; + } + } + @Override public VdsStatistics get(Guid id) { MapSqlParameterSource parameterSource = getCustomMapSqlParameterSource() .addValue("vds_id", id); - ParameterizedRowMapper<VdsStatistics> mapper = new ParameterizedRowMapper<VdsStatistics>() { - @Override - public VdsStatistics mapRow(ResultSet rs, int rowNum) - throws SQLException { - VdsStatistics entity = new VdsStatistics(); - entity.setcpu_idle(rs.getDouble("cpu_idle")); - entity.setcpu_load(rs.getDouble("cpu_load")); - entity.setcpu_sys(rs.getDouble("cpu_sys")); - entity.setcpu_user(rs.getDouble("cpu_user")); - entity.setusage_cpu_percent((Integer) rs - .getObject("usage_cpu_percent")); - entity.setusage_mem_percent((Integer) rs - .getObject("usage_mem_percent")); - entity.setusage_network_percent((Integer) rs - .getObject("usage_network_percent")); - entity.setId(Guid.createGuidFromString(rs - .getString("vds_id"))); - entity.setmem_available(rs.getLong("mem_available")); - entity.setmem_shared(rs.getLong("mem_shared")); - entity.setswap_free(rs.getLong("swap_free")); - entity.setswap_total(rs.getLong("swap_total")); - entity.setksm_cpu_percent((Integer) rs - .getObject("ksm_cpu_percent")); - entity.setksm_pages(rs.getLong("ksm_pages")); - entity.setksm_state((Boolean) rs.getObject("ksm_state")); - return entity; - } - }; - - return getCallsHandler().executeRead("GetVdsStatisticsByVdsId", mapper, parameterSource); + return getCallsHandler().executeRead("GetVdsStatisticsByVdsId", + VdsStatisticsRowMapper.instance, + parameterSource); } @Override -- To view, visit http://gerrit.ovirt.org/12577 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I138a81d75fd2965eb15979aa925687f64bb19fbc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
