Ofer Schreiber has posted comments on this change. Change subject: packaging: Updated order of services starting ......................................................................
Patch Set 3: I would prefer that you didn't submit this (1 inline comment) .................................................... File packaging/fedora/setup/engine-upgrade.py Line 1102: # If something went wrong, restart DB services and the engine Line 1103: except: Line 1104: runFunc(startEngineService, MSG_INFO_START_ENGINE % engineService) Line 1105: if updateRelatedToDB: Line 1106: time.sleep(WAIT_DWHD) Adding this "sleep" operation without any information to the user is problematic Line 1107: runFunc([[startDbRelatedServices, etlService, notificationService]], MSG_INFO_START_DB) Line 1108: raise Line 1109: else: Line 1110: # This means that user chose not to stop ovirt-engine -- To view, visit http://gerrit.ovirt.org/12405 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I51d67f7cb88ae6aef74e2ecabff85c7828d697d2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Moran Goldboim <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Yaniv Dary <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
