Michael Pasternak has posted comments on this change.
Change subject: restapi : NullPointerException when Authorization header is
passed(#916085)
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/security/auth/LoginValidator.java
Line 143: return loginFailure(principal, reasons != null ?
reasons.toString() : null);
Line 144: }
Line 145:
Line 146: private boolean loginFailureNoPrincipal() {
Line 147: LOG.infoFormat(LOGIN_FAILURE_NO_PRINCIPAL);
this is a result of missing Authorization-Type. not a cause,
i'd use a bit more verbose message like "authorization is failed due to missing
authorization-type" in relevant place.
Line 148: return false;
Line 149: }
Line 150:
Line 151: private boolean loginFailure(Principal principal, String reason) {
--
To view, visit http://gerrit.ovirt.org/12501
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I10b580dcc3fddbec8ccd80130e977aeb4ef37fb2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
