Daniel Erez has uploaded a new change for review. Change subject: webadmin: use ValidatedPanelWidget where applicable ......................................................................
webadmin: use ValidatedPanelWidget where applicable Using ValidatedPanelWidget instead of manual validation: * Attach disk panel * iSCSI/FCP panel Change-Id: I80a69c3767b1f55d0846fa65386cc02082965798 Signed-off-by: Daniel Erez <[email protected]> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValidatedPanelWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml 9 files changed, 57 insertions(+), 167 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/83/12583/1 diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValidatedPanelWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValidatedPanelWidget.java index 0aa3567..eb86028 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValidatedPanelWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/ValidatedPanelWidget.java @@ -19,18 +19,17 @@ initWidget(WidgetUiBinder.uiBinder.createAndBindUi(this)); } - @Override - protected Widget getValidatedWidget() { - return panel; + public ValidatedPanelWidget(Widget contentWidget) { + this(); + setWidget(contentWidget); } - public void setPanelWidget(Widget widget) { + public void setWidget(Widget widget) { panel.setWidget(widget); } @Override - public void markAsValid() { - super.markAsValid(); - getValidatedWidgetStyle().setBorderColor("transparent"); //$NON-NLS-1$ + protected Widget getValidatedWidget() { + return panel; } } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java index cbef76f..043da35 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java @@ -60,7 +60,6 @@ import com.google.gwt.user.client.ui.HorizontalPanel; import com.google.gwt.user.client.ui.Label; import com.google.gwt.user.client.ui.RadioButton; -import com.google.gwt.user.client.ui.SimplePanel; import com.google.gwt.user.client.ui.VerticalPanel; public class VmDiskPopupWidget extends AbstractModelBoundPopupWidget<DiskModel> { @@ -169,7 +168,7 @@ VerticalPanel attachDiskPanel; @UiField - SimplePanel innerAttachDiskPanel; + ValidatedPanelWidget innerAttachDiskPanel; @UiField FlowPanel externalDiskPanel; @@ -202,9 +201,6 @@ @Ignore AbstractStorageView storageView; - - @Ignore - ValidatedPanelWidget attachPanelWidget; boolean isNewLunDiskEnabled; StorageModel storageModel; @@ -296,9 +292,7 @@ verticalPanel.add(externalDiskTable); // Create ValidatedPanelWidget and add tables container - attachPanelWidget = new ValidatedPanelWidget(); - attachPanelWidget.setPanelWidget(verticalPanel); - innerAttachDiskPanel.add(attachPanelWidget); + innerAttachDiskPanel.setWidget(verticalPanel); } private void initInternalDiskTable(final CommonApplicationConstants constants, @@ -570,7 +564,7 @@ iscsiStorageModel.getPropertyChangedEvent().addListener(progressEventHandler); iscsiStorageModel.setIsGrouppedByTarget(true); iscsiStorageModel.setIgnoreGrayedOut(true); - iscsiStorageView = new IscsiStorageView(false, 108, 207, 246, 268, 275, 125, 55, -59); + iscsiStorageView = new IscsiStorageView(false, 108, 206, 246, 275, 125, 55, -59); iscsiStorageView.edit(iscsiStorageModel); // Create FcpStorageModel @@ -611,9 +605,9 @@ String propName = ((PropertyChangedEventArgs) args).PropertyName; if (propName.equals("IsValid")) { //$NON-NLS-1$ if (disk.getIsValid()) { - attachPanelWidget.markAsValid(); + innerAttachDiskPanel.markAsValid(); } else { - attachPanelWidget.markAsInvalid(disk.getInvalidityReasons()); + innerAttachDiskPanel.markAsInvalid(disk.getInvalidityReasons()); } } } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml index b94f52f..ba85e6b 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.ui.xml @@ -1,18 +1,13 @@ <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";> <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder" xmlns:g="urn:import:com.google.gwt.user.client.ui" - xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor"> + xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor" xmlns:w="urn:import:org.ovirt.engine.ui.common.widget"> <ui:with field='constants' type='org.ovirt.engine.ui.common.CommonApplicationConstants' /> <ui:style> .container { width: 100%; - } - - .macExample { - color: gray; - float: right; } .errorMessageLabel { @@ -71,6 +66,14 @@ bottom: 0px; position: absolute; } + + .attachDiskPanel { + position: absolute; + top: 80px; + bottom: 50px; + padding: 2px; + margin-right: 2px; + } </ui:style> <g:FlowPanel addStyleNames="{style.container}"> @@ -105,9 +108,7 @@ <g:FlowPanel ui:field="externalDiskPanel" addStyleNames="{style.externalDiskPanel}"/> </g:VerticalPanel> <g:VerticalPanel ui:field="attachDiskPanel" addStyleNames="{style.mainPanel}" visible="false"> - <g:ScrollPanel height="410px"> - <g:SimplePanel ui:field="innerAttachDiskPanel" width="100%" height="100%"/> - </g:ScrollPanel> + <w:ValidatedPanelWidget ui:field="innerAttachDiskPanel" addStyleNames="{style.attachDiskPanel}" /> <e:EntityModelCheckBoxEditor ui:field="isPluggedEditor" addStyleNames="{style.isPluggedEditor}" /> </g:VerticalPanel> </g:FlowPanel> diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.ui.xml index 4ef6e63..88c760f 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageList.ui.xml @@ -6,7 +6,6 @@ .treeContainer { width: 100%; overflow-y: scroll !important; - margin-bottom: 2px; } </ui:style> diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java index f2bc449..cd08e3c 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.java @@ -4,6 +4,7 @@ import org.ovirt.engine.ui.common.CommonApplicationConstants; import org.ovirt.engine.ui.common.widget.HasValidation; +import org.ovirt.engine.ui.common.widget.ValidatedPanelWidget; import org.ovirt.engine.ui.uicommonweb.models.EntityModel; import org.ovirt.engine.ui.uicommonweb.models.storage.SanStorageModelBase; import org.ovirt.engine.ui.uicompat.Event; @@ -13,12 +14,8 @@ import com.google.gwt.core.client.GWT; import com.google.gwt.editor.client.SimpleBeanEditorDriver; -import com.google.gwt.resources.client.CssResource; import com.google.gwt.uibinder.client.UiBinder; import com.google.gwt.uibinder.client.UiField; -import com.google.gwt.user.client.ui.FlowPanel; -import com.google.gwt.user.client.ui.Label; -import com.google.gwt.user.client.ui.ScrollPanel; import com.google.gwt.user.client.ui.Widget; import com.google.inject.Inject; @@ -33,20 +30,7 @@ } @UiField - WidgetStyle style; - - @UiField - ScrollPanel listPanel; - - @UiField - FlowPanel contentPanel; - - @UiField - FlowPanel extraContentPanel; - - @UiField - @Ignore - Label listLabel; + ValidatedPanelWidget contentPanel; protected static final CommonApplicationConstants constants = GWT.create(CommonApplicationConstants.class); @@ -99,26 +83,12 @@ @Override public void markAsValid() { - markValidation(false, null); + contentPanel.markAsValid(); } @Override public void markAsInvalid(List<String> validationHints) { - markValidation(true, validationHints); - } - - private void markValidation(boolean isValid, List<String> validationHints) { - String oldStyle = isValid ? style.validContentPanel() : style.invalidContentPanel(); - String newStyle = isValid ? style.invalidContentPanel() : style.validContentPanel(); - - contentPanel.removeStyleName(oldStyle); - contentPanel.addStyleName(newStyle); - - contentPanel.setTitle(getValidationTitle(validationHints)); - } - - private String getValidationTitle(List<String> validationHints) { - return validationHints != null && validationHints.size() > 0 ? validationHints.get(0) : null; + contentPanel.markAsInvalid(validationHints); } @Override @@ -128,15 +98,5 @@ @Override public void focus() { - } - - interface WidgetStyle extends CssResource { - String validContentPanel(); - - String invalidContentPanel(); - - String listPanel(); - - String treePanel(); } } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.ui.xml index 9bb976a..71226f3 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/AbstractSanStorageView.ui.xml @@ -1,49 +1,25 @@ <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";> <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder" xmlns:g="urn:import:com.google.gwt.user.client.ui" - xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog" xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor"> + xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog" xmlns:e="urn:import:org.ovirt.engine.ui.common.widget.editor" + xmlns:w="urn:import:org.ovirt.engine.ui.common.widget"> - <ui:style type="org.ovirt.engine.ui.common.widget.uicommon.storage.AbstractSanStorageView.WidgetStyle"> + <ui:style> .contentPanel { padding: 2px; margin: 4px; } - - .validContentPanel { - border: 1px lightGray solid; - } - - .invalidContentPanel { - border: 1px orange solid; - } - - .listPanel { - height: 100%; - } - - .treePanel { - height: 100%; - overflow: auto; - } - + .errorMessageLabel { color: red; margin: 2px; height: 16px; } - - .listLabel { - margin: 2px; - } </ui:style> <g:FlowPanel> <g:Label ui:field="errorMessage" addStyleNames="{style.errorMessageLabel}" /> - <g:FlowPanel ui:field="contentPanel" addStyleNames="{style.contentPanel} {style.validContentPanel}"> - <g:FlowPanel ui:field="extraContentPanel" /> - <g:Label ui:field="listLabel" addStyleNames="{style.listLabel}" /> - <g:ScrollPanel ui:field="listPanel" addStyleNames="{style.listPanel}" /> - </g:FlowPanel> + <w:ValidatedPanelWidget ui:field="contentPanel" addStyleNames="{style.contentPanel}" /> </g:FlowPanel> </ui:UiBinder> diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java index 9525071..47e58a1 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/FcpStorageView.java @@ -39,6 +39,6 @@ contentPanel.getElement().getStyle().setHeight(panelHeight, Unit.PX); // Add view widget to panel - listPanel.add(sanStorageLunToTargetList); + contentPanel.setWidget(sanStorageLunToTargetList); } } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java index aa0ba4b..250be1e 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.java @@ -4,6 +4,7 @@ import org.ovirt.engine.ui.common.CommonApplicationConstants; import org.ovirt.engine.ui.common.widget.HasValidation; +import org.ovirt.engine.ui.common.widget.ValidatedPanelWidget; import org.ovirt.engine.ui.common.widget.dialog.tab.DialogTab; import org.ovirt.engine.ui.common.widget.dialog.tab.DialogTabPanel; import org.ovirt.engine.ui.uicommonweb.models.EntityModel; @@ -21,10 +22,8 @@ import com.google.gwt.resources.client.CssResource; import com.google.gwt.uibinder.client.UiBinder; import com.google.gwt.uibinder.client.UiField; -import com.google.gwt.user.client.ui.FlowPanel; import com.google.gwt.user.client.ui.HasHorizontalAlignment; import com.google.gwt.user.client.ui.Label; -import com.google.gwt.user.client.ui.SimplePanel; import com.google.gwt.user.client.ui.Widget; public class IscsiStorageView extends AbstractStorageView<IscsiStorageModel> implements HasValidation { @@ -58,16 +57,10 @@ DialogTabPanel dialogTabPanel; @UiField - SimplePanel lunsListPanel; + ValidatedPanelWidget lunsListPanel; @UiField - SimplePanel targetsToLunsPanel; - - @UiField - FlowPanel targetsToLunsTabContentPanel; - - @UiField - FlowPanel lunsToTargetsTabContentPanel; + ValidatedPanelWidget targetsToLunsPanel; @Ignore IscsiTargetToLunView iscsiTargetToLunView; @@ -75,8 +68,8 @@ @Ignore IscsiLunToTargetView iscsiLunToTargetView; - double treeCollapsedHeight = 208, treeExpandedHeight = 307, lunsTreeHeight = 345; - double tabPanelHeight = 368, tabContentHeight = 340, tabHeight = 175; + double treeCollapsedHeight = 208, treeExpandedHeight = 306, lunsTreeHeight = 345; + double tabContentHeight = 340, tabHeight = 175; double textTop = 80, textLeft = -84, textWidth = 100; protected static final CommonApplicationConstants constants = GWT.create(CommonApplicationConstants.class); @@ -91,14 +84,13 @@ public IscsiStorageView(boolean multiSelection, double treeCollapsedHeight, double treeExpandedHeight, double lunsTreeHeight, - double tabPanelHeight, double tabContentHeight, double tabHeight, + double tabContentHeight, double tabHeight, double textTop, double textLeft) { this(multiSelection); this.treeCollapsedHeight = treeCollapsedHeight; this.treeExpandedHeight = treeExpandedHeight; this.lunsTreeHeight = lunsTreeHeight; - this.tabPanelHeight = tabPanelHeight; this.tabContentHeight = tabContentHeight; this.tabHeight = tabHeight; this.textTop = textTop; @@ -172,16 +164,15 @@ // Update Style dialogTabPanel.getElement().getStyle().setHeight(tabContentHeight, Unit.PX); - updateStyle(targetsToLunsTabContentPanel, targetsToLunTab); - updateStyle(lunsToTargetsTabContentPanel, lunToTargetsTab); + updateStyle(targetsToLunTab); + updateStyle(lunToTargetsTab); // Add view widgets to panel - lunsListPanel.add(iscsiLunToTargetView); - targetsToLunsPanel.add(iscsiTargetToLunView); + lunsListPanel.setWidget(iscsiLunToTargetView); + targetsToLunsPanel.setWidget(iscsiTargetToLunView); } - void updateStyle(FlowPanel tabContentPanel, DialogTab dialogTab) { - tabContentPanel.getElement().getStyle().setHeight(tabPanelHeight, Unit.PX); + void updateStyle(DialogTab dialogTab) { dialogTab.getElement().getStyle().setHeight(tabHeight, Unit.PX); dialogTab.getTabLabel().getElement().getStyle().setTop(textTop, Unit.PX); dialogTab.getTabLabel().getElement().getStyle().setLeft(textLeft, Unit.PX); @@ -210,29 +201,14 @@ @Override public void markAsValid() { - markValidation(false, null); + lunsListPanel.markAsValid(); + targetsToLunsPanel.markAsValid(); } @Override public void markAsInvalid(List<String> validationHints) { - markValidation(true, validationHints); - } - - private void markValidation(boolean isValid, List<String> validationHints) { - String oldStyle = isValid ? style.validTabContentPanel() : style.invalidTabContentPanel(); - String newStyle = isValid ? style.invalidTabContentPanel() : style.validTabContentPanel(); - - targetsToLunsTabContentPanel.removeStyleName(oldStyle); - lunsToTargetsTabContentPanel.removeStyleName(oldStyle); - targetsToLunsTabContentPanel.addStyleName(newStyle); - lunsToTargetsTabContentPanel.addStyleName(newStyle); - - targetsToLunsTabContentPanel.setTitle(getValidationTitle(validationHints)); - lunsToTargetsTabContentPanel.setTitle(getValidationTitle(validationHints)); - } - - private String getValidationTitle(List<String> validationHints) { - return validationHints != null && validationHints.size() > 0 ? validationHints.get(0) : null; + lunsListPanel.markAsInvalid(validationHints); + targetsToLunsPanel.markAsInvalid(validationHints); } @Override @@ -255,10 +231,6 @@ String dialogTab(); String expandedlunsListPanel(); - - String validTabContentPanel(); - - String invalidTabContentPanel(); } } diff --git a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml index 32f0660..9fbf74d 100644 --- a/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml +++ b/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/storage/IscsiStorageView.ui.xml @@ -1,13 +1,14 @@ <?xml version="1.0" encoding="UTF-8"?> <!DOCTYPE ui:UiBinder SYSTEM "http://dl.google.com/gwt/DTD/xhtml.ent";> <ui:UiBinder xmlns:ui="urn:ui:com.google.gwt.uibinder" xmlns:g="urn:import:com.google.gwt.user.client.ui" - xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog" xmlns:t="urn:import:org.ovirt.engine.ui.common.widget.dialog.tab"> + xmlns:d="urn:import:org.ovirt.engine.ui.common.widget.dialog" xmlns:t="urn:import:org.ovirt.engine.ui.common.widget.dialog.tab" + xmlns:w="urn:import:org.ovirt.engine.ui.common.widget"> <ui:style type="org.ovirt.engine.ui.common.widget.uicommon.storage.IscsiStorageView.WidgetStyle"> .bar { - width: 20px; + width: 20px !important; } - + .dialogTab { position: relative; white-space: nowrap; @@ -16,34 +17,26 @@ -moz-transform: rotate(-90deg); -ms-transform: rotate(-90deg); } - + .tabPanel { display: inline-block; } - + .tabContentPanel { padding: 2px; margin-right: 2px; } - - .validTabContentPanel { - border: 1px lightGray solid; - } - - .invalidTabContentPanel { - border: 1px orange solid; - } - + .targetsListPanel { margin-top: 35px; } - + .expandedlunsListPanel { width: 100%; overflow-y: scroll !important; overflow-x: auto; } - + .errorMessageLabel { color: red; margin: 2px; @@ -60,18 +53,14 @@ <t:tab> <t:DialogTab ui:field="targetsToLunTab"> <t:content height="100%"> - <g:FlowPanel ui:field="targetsToLunsTabContentPanel" addStyleNames="{style.tabContentPanel} {style.validTabContentPanel}"> - <g:SimplePanel ui:field="targetsToLunsPanel" /> - </g:FlowPanel> + <w:ValidatedPanelWidget ui:field="targetsToLunsPanel" addStyleNames="{style.tabContentPanel}" /> </t:content> </t:DialogTab> </t:tab> <t:tab> <t:DialogTab ui:field="lunToTargetsTab"> <t:content height="100%"> - <g:FlowPanel ui:field="lunsToTargetsTabContentPanel" addStyleNames="{style.tabContentPanel} {style.validTabContentPanel}"> - <g:SimplePanel ui:field="lunsListPanel" /> - </g:FlowPanel> + <w:ValidatedPanelWidget ui:field="lunsListPanel" addStyleNames="{style.tabContentPanel}" /> </t:content> </t:DialogTab> </t:tab> -- To view, visit http://gerrit.ovirt.org/12583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I80a69c3767b1f55d0846fa65386cc02082965798 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
