Ofer Schreiber has posted comments on this change.
Change subject: packaging: Added checking DB state before upgrade
......................................................................
Patch Set 4: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File packaging/fedora/setup/engine-upgrade.py
Line 836: if rc > 1:
Line 837: raise Exception(output_messages.ERR_CANT_CLEAR_ZOMBIE_TASKS)
Line 838:
Line 839:
Line 840: def db_validation_fails():
we use camelCase in engine setup....
Line 841: '''
Line 842: Check db for inconsistencies
Line 843: '''
Line 844: cmd = [
Line 856: envDict=utils.getPgEnv(),
Line 857: )
Line 858:
Line 859: # Check the content of the output
Line 860: # If it's not empty, return True
This is a VERY problematic API.
can't it return RC zero on success and RC > 0 otherwise?
Line 861: if len(out):
Line 862: for line in out.split('\n'):
Line 863: if len(line.strip()):
Line 864: return True
--
To view, visit http://gerrit.ovirt.org/12512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief0e65231bb42b569734cdd2fa6491b645491f98
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
