Alona Kaplan has posted comments on this change.
Change subject: webadmin: Fixed NIC sorting in Setup Networks popup
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
Line 558: Map<String, List<String>> bondToNic = new HashMap<String,
List<String>>();
Line 559: Map<String, List<String>> nicToNetwork = new HashMap<String,
List<String>>();
Line 560:
Line 561: Collections.sort(allNics, new
Comparator<VdsNetworkInterface>() {
Line 562:
I"m not sure how your fix can work.
The view is using nicMap.values() (not allNics) to display the nics. nicMap is
a HashMap, which makes no guarantees as to the order of the map. If you want to
keep the sort on the model side, nicsMap should be SortedMap (LinkedHashMap,
TreeMap...)
Line 563: private LexoNumericComparator lexoNumeric = new
LexoNumericComparator();
Line 564:
Line 565: @Override
Line 566: public int compare(VdsNetworkInterface nic1,
VdsNetworkInterface nic2) {
--
To view, visit http://gerrit.ovirt.org/12149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I39928e5c56d110c9c36694e4fc78a2c943023961
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
