Vered Volansky has posted comments on this change.
Change subject: core: Add ImagesHandler.filterEditableImageDisks
......................................................................
Patch Set 4: (1 inline comment)
If it indeed doesn't matter to all disk types and two boolean values then I
suggest removing it altogether.
If (true, true) is different than the three other combinations (which are the
same), and there is indeed use for it in future use, then this method should be
kept, but not as it is (just a different name and the different functionality,
without the two booleans).
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
Line 610: return diskImages;
Line 611: }
Line 612:
Line 613: public static List<DiskImage>
filterEditableImageDisks(Collection<? extends Disk> listOfDisks) {
Line 614: return filterImageDisks(listOfDisks, true, true);
In the test you proved your point for everything other than (true, true).
Line 615: }
Line 616:
Line 617: public static List<LunDisk>
filterDiskBasedOnLuns(Collection<Disk> listOfDisks) {
Line 618: List<LunDisk> lunDisks = new ArrayList<LunDisk>();
--
To view, visit http://gerrit.ovirt.org/12320
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f766309911d27503dbbb80a07fcc776d9068cd2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
