Allon Mureinik has uploaded a new change for review. Change subject: core: DbUserCacheManager: iterate entrySet() ......................................................................
core: DbUserCacheManager: iterate entrySet() Iterate over entrySet() instead of iterating over keySet() and calling get, for better performance. Change-Id: I8db1dd978760eb961a7e17c36a99ff4f8a2c4917 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java 1 file changed, 7 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/08/12608/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java index d00cb62..4736212 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DbUserCacheManager.java @@ -178,13 +178,16 @@ if (userByDomains.size() != 0) { // Refresh users in each domain separately - for (String domain : userByDomains.keySet()) { + for (Map.Entry<String, Map<Guid, DbUser>> entry : userByDomains.entrySet()) { + String domain = entry.getKey(); List<LdapUser> adUsers = (List<LdapUser>) LdapFactory.getInstance(domain) .RunAdAction( AdActionType.GetAdUserByUserIdList, - new LdapSearchByUserIdListParameters(domain, new ArrayList<Guid>(userByDomains - .get(domain).keySet()),false)).getReturnValue(); + new LdapSearchByUserIdListParameters(domain, + new ArrayList<Guid>(entry.getValue().keySet()), + false)) + .getReturnValue(); HashSet<Guid> updatedUsers = new HashSet<Guid>(); if (adUsers == null) { log.warn("No users returned from directory server during refresh users"); @@ -195,7 +198,7 @@ userByDomains.get(domain).remove(adUser.getUserId()); } } - Collection<DbUser> usersForDomain = userByDomains.get(domain).values(); + Collection<DbUser> usersForDomain = entry.getValue().values(); if (usersForDomain == null) { log.warnFormat("No users for domain {0}",domain); } else { -- To view, visit http://gerrit.ovirt.org/12608 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8db1dd978760eb961a7e17c36a99ff4f8a2c4917 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
