Yair Zaslavsky has posted comments on this change.
Change subject: core: provided cleared frontend logging
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionParametersBase.java
Line 300: StringBuilder builder = new StringBuilder(50);
Line 301: builder.append("commandId: "); //$NON-NLS-1$
Line 302: builder.append(getCommandId());
Line 303: builder.append(", user: "); //$NON-NLS-1$
Line 304: builder.append(getParametersCurrentUser().getUserName());
Can't this cause NPE? what is the user in case of internal command?
Line 305: builder.append(", commandType: "); //$NON-NLS-1$
Line 306: builder.append(getCommandType());
Line 307: return builder.toString();
Line 308: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryParametersBase.java
Line 62:
Line 63: @Override
Line 64: public String toString() {
Line 65: StringBuilder builder = new StringBuilder(25);
Line 66: builder.append("Is refresh? ");
I would prefer "refresh" and "filtered" without the ?
Line 67: builder.append(refresh);
Line 68: builder.append(", Is filtered? ");
Line 69: builder.append(isFiltered);
Line 70: return builder.toString();
--
To view, visit http://gerrit.ovirt.org/12559
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I845aa47da03168f1a0f988203df7ab0a51e94804
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
