Liron Aravot has posted comments on this change.
Change subject: [wip] core: storage domain failover process never runs
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/eventqueue/EventQueueMonitor.java
Line 67: try {
Line 68: Event currentEvent =
poolCurrentEventMap.get(storagePoolId);
Line 69: if (currentEvent != null) {
Line 70: switch (currentEvent.getEventType()) {
Line 71: case RECOVERY:
Michael, we discussed it but before submitting again i want to ask, are we sure
that we don't to add also DOMAINMONITORING event (seems that it can only save
us operations), if we already add always this two - so that we will have all
domain related events added and kept in the queue, what do you say? I think it
will be more readable that way (all domain related events are added) and also
we might possibly save some operations/issues and time - what do you think?
Line 72: if (event.getEventType() ==
EventType.VDSCONNECTTOPOOL || event.getEventType() == EventType.VDSCLEARCACHE) {
Line 73: task = addTaskToQueue(event, callable,
storagePoolId, isEventShouldBeFirst(event));
Line 74: } else {
Line 75: log.debugFormat("Current event was skiped
because of recovery is running now for pool {0}, event {1}",
--
To view, visit http://gerrit.ovirt.org/12237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1a45098dc4eb2607dd12dabf3c0d526e8bebca7
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Liron Aravot <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
