Yair Zaslavsky has posted comments on this change.
Change subject: restapi : Creating template by specifing vm name, does not work
(#915285)
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmByVmNameForDataCenterQuery.java
Line 7: public GetVmByVmNameForDataCenterQuery(P parameters) {
Line 8: super(parameters);
Line 9: }
Line 10:
Line 11: @Override
I would prefer new queries have tests, we have plenty examples on how to do
that.
Line 12: protected void executeQueryCommand() {
Line 13: VM vm = getDbFacade().getVmDao().getByNameForDataCenter(
Line 14: getParameters().getDataCenterId(),
Line 15: getParameters().getName(),
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmByVmNameForDataCenterParameters.java
Line 3: import org.ovirt.engine.core.compat.Guid;
Line 4:
Line 5: public class GetVmByVmNameForDataCenterParameters extends
VdcQueryParametersBase {
Line 6: private static final long serialVersionUID = -3232978226860645746L;
Line 7: private Guid _dataCenterId;
I prefer not to have underscores :)
Line 8: private String _name;
Line 9:
Line 10: public GetVmByVmNameForDataCenterParameters(Guid dataCenterId,
String name) {
Line 11: _dataCenterId = dataCenterId;
--
To view, visit http://gerrit.ovirt.org/12426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe6ff6059c22a853c76a0720e5c9e330f600712b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
