Omer Frenkel has posted comments on this change.
Change subject: Trusted Compute Pools - Open Attestation integration with oVirt
engine proposal
......................................................................
Patch Set 3: (2 inline comments)
few general comments:
please use project formatter (see under config/engine-code-format.xml) on all
changed code.
i wonder why this is only in vm and not in template as well?
also there is no support for trust level in import/export
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/attestationbroker/AttestationCacheManager.java
Line 9:
Line 10: private static final AttestationCacheManager instance = new
AttestationCacheManager();
Line 11: //TODO Consider clearing cache when there are no softreference?
Line 12: private static ConcurrentHashMap<String, AttestationValue>
attestationValues = new ConcurrentHashMap<String, AttestationValue>();
Line 13: private static long cacheTimeout = Long.valueOf(Config.<String>
GetValue(ConfigValues.CacheTimeout)).longValue();
please check comment on the ConfigValues class
Line 14:
Line 15: public AttestationCacheManager getInstance(){
Line 16: return instance;
Line 17: }
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java
Line 1343: @TypeConverterAttribute(String.class)
Line 1344: @DefaultValueAttribute("TrustStore.jks")
Line 1345: AttestationTruststore(413),
Line 1346:
Line 1347: @TypeConverterAttribute(String.class)
you should define this value as long and then you can use it this way:
Config.<Long> GetValue(..)
instead of parsing a string in the code
Line 1348: @DefaultValueAttribute("36000000")
Line 1349: CacheTimeout(414),
Line 1350:
Line 1351: @TypeConverterAttribute(Integer.class)
--
To view, visit http://gerrit.ovirt.org/11237
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4de780cd46069638433255f3f9c994575f752e55
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dave Chen <[email protected]>
Gerrit-Reviewer: Dave Chen <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: ofri masad <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
