Juan Hernandez has posted comments on this change.
Change subject: packaging: support and use engine conf.d structure
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File packaging/50-ovirt-engine-reports.conf
Line 1: ENGINE_APPS="${ENGINE_APPS} ovirt-engine-reports.war"
Line 2: ENGINE_PROPERTIES="${ENGINE_PROPERTIES}
-Dorg.apache.tomcat.util.http.ServerCookie.ALLOW_HTTP_SEPARATORS_IN_V0=true"
Do you want to apply these settings before the settings generated by
engine-setup? Shuldn't this be named "60-whatever.conf" to make sure that
reports settings are applied after engine-setup settings?
Now that this is a separate file some comments explaining why this is needed
would be appreciated.
....................................................
File packaging/ovirt-engine-reports-setup.py
Line 443: return True
Line 444: else:
Line 445: return False
Line 446:
Line 447: def getHostParams(secure=True):
This method will not work if the user decides to use the ${...} syntax in any
of the configuration files.
Line 448: """
Line 449: get protocol, hostname & secured port from
/etc/ovirt-engine/engine.conf
Line 450: """
Line 451:
....................................................
File packaging/ovirt-engine-reports.spec.in
Line 110: fi
Line 111: fi
Line 112:
Line 113: %files
Line 114: %{_sysconfdir}/ovirt-engine/engine.conf.d/50-ovirt-engine-reports.conf
This file should be marked as configuration.
Line 115: %{reports_java}
Line 116: %{_datadir}/%{reports_name}
Line 117: %if "%{name}" != "%{reports_name}"
Line 118: %{_javadir}/%{name}
--
To view, visit http://gerrit.ovirt.org/12736
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce91e23038b55e338b906d46937e9433f4f18bc
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Yaniv Dary <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
