Sandro Bonazzola has posted comments on this change.
Change subject: tools: fixed command line parser setup
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File src/__main__.py
Line 104: pg_user = get_pg_var('admin') or pg_user
Line 105: pg_pass = get_pg_var('pass', pg_user) or pg_pass
Line 106: pg_dbhost = get_pg_var('host') or pg_dbhost
Line 107: pg_dbport = get_pg_var('port') or pg_dbport
Line 108: except Exception as e:
get_pg_var just raise Exception. I can change it to ValueError since the
exception says "unknown value" and exiting with critical error in this case.
Line 109: print "Warning: error while reading .pgpass configuration:
%s" % str(e)
Line 110: ExitCodes.exit_code = ExitCodes.WARN
Line 111:
Line 112:
--
To view, visit http://gerrit.ovirt.org/12729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I284554888143ad27bca0630cdbc26e91cf735ab9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
